NotAShelf/rogged
1
1
Fork 1
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

various: more render code cleanup #12

Manually merged
NotAShelf merged 3 commits from notashelf/push-xqnuklotzqqk into main 2026-04-08 14:42:18 +00:00
Conversation 2 Commits 3 Files changed 5 +173 -62
NotAShelf commented 2026-04-08 13:33:09 +00:00
Owner
Copy link

Extract magic strings, null checks, yada yada.

Extract magic strings, null checks, yada yada.
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I007a86584f618f990f7a5ed569115aeb6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ie5cadb3d9dca130b57b858905f549f2d6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I29c5feb6099fe321e227e0313282f1546a6a6964
NotAShelf force-pushed notashelf/push-xqnuklotzqqk from 1f26f171fe to eed5c3aff3 2026-04-08 13:33:16 +00:00 Compare
NotAShelf commented 2026-04-08 13:34:11 +00:00
Author
Owner
Copy link

I was going to send this later but I decided to complete one more PR before I head off. Might be a nice time to address any leftover comments from #10 also

I was going to send this later but I decided to complete one more PR before I head off. Might be a nice time to address any leftover comments from #10 also
NotAShelf requested review from amr 2026-04-08 13:36:02 +00:00
amr approved these changes 2026-04-08 14:39:39 +00:00
amr left a comment
Collaborator
Copy link

This looks great. The new font stuff I'm implementing will be much better handled in settings.h as well, so it's good to move all the magic numbers there. Also this makes the code much neater and more readable.

This looks great. The new font stuff I'm implementing will be much better handled in settings.h as well, so it's good to move all the magic numbers there. Also this makes the code much neater and more readable.
👍 1 ❤️ 1
NotAShelf manually merged commit eed5c3aff3 into main 2026-04-08 14:42:18 +00:00
NotAShelf deleted branch notashelf/push-xqnuklotzqqk 2026-04-08 14:44:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
amr
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
NotAShelf/rogged!12
No description provided.