From 225049b5105f3de06dcc40f4347a3982b6c5545d Mon Sep 17 00:00:00 2001 From: Frankie Date: Mon, 27 Nov 2023 21:31:22 +0000 Subject: [PATCH] fix: snowflakes falling below window viewport --- public/js/christmas/snow.js | 81 +++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/public/js/christmas/snow.js b/public/js/christmas/snow.js index 7e845d4..3d2d7af 100644 --- a/public/js/christmas/snow.js +++ b/public/js/christmas/snow.js @@ -7,7 +7,6 @@ // - Made snowflakes randomly rotate slowly either right or left */ - // Amount of Snowflakes var snowMax = 80; @@ -43,70 +42,72 @@ var snowStyles = "cursor: default; -webkit-user-select: none; -moz-user-select: */ var snow = [], - pos = [], - coords = [], - lefr = [], - marginBottom, - marginRight; + pos = [], + coords = [], + lefr = [], + marginBottom, + marginRight; function randomise(range) { - rand = Math.floor(range * Math.random()); - return rand; + rand = Math.floor(range * Math.random()); + return rand; } function initSnow() { - var snowSize = snowMaxSize - snowMinSize; - marginBottom = window.screen.height - 5; - marginRight = document.body.clientWidth - 15; + var snowSize = snowMaxSize - snowMinSize; + marginBottom = Math.max(document.body.scrollHeight, window.innerHeight) - 5; + marginRight = document.body.clientWidth - 15; - for (i = 0; i <= snowMax; i++) { - coords[i] = 0; - lefr[i] = Math.random() * 15; - pos[i] = 0.03 + Math.random() / 10; - snow[i] = document.getElementById("flake" + i); - snow[i].style.fontFamily = "inherit"; - snow[i].size = randomise(snowSize) + snowMinSize; - snow[i].style.fontSize = snow[i].size + "px"; - snow[i].style.color = snowColor[randomise(snowColor.length)]; - snow[i].style.zIndex = 1000; - snow[i].sink = snowSpeed * snow[i].size / 5; - snow[i].posX = randomise(marginRight - snow[i].size); - snow[i].posY = randomise(2 * marginBottom - marginBottom - 2 * snow[i].size); - snow[i].style.left = snow[i].posX + "px"; - snow[i].style.top = snow[i].posY + "px"; + for (i = 0; i <= snowMax; i++) { + coords[i] = 0; + lefr[i] = Math.random() * 15; + pos[i] = 0.03 + Math.random() / 10; + snow[i] = document.getElementById("flake" + i); + snow[i].style.fontFamily = "inherit"; + snow[i].size = randomise(snowSize) + snowMinSize; + snow[i].style.fontSize = snow[i].size + "px"; + snow[i].style.color = snowColor[randomise(snowColor.length)]; + snow[i].style.zIndex = 1000; + snow[i].sink = snowSpeed * snow[i].size / 5; + snow[i].posX = randomise(marginRight - snow[i].size); + snow[i].posY = randomise(2 * marginBottom - marginBottom - 2 * snow[i].size); + snow[i].style.left = snow[i].posX + "px"; + snow[i].style.top = snow[i].posY + "px"; snow[i].rotation = Math.random() * 360; // add a random initial rotation snow[i].direction = Math.random() > 0.5 ? 1 : -1; // add a random direction } - moveSnow(); + moveSnow(); } function resize() { - marginBottom = window.screen.height - 5; - marginRight = document.body.clientWidth - 15; + marginBottom = Math.max(document.body.scrollHeight, window.innerHeight) - 5; + marginRight = document.body.clientWidth - 15; } function moveSnow() { - for (i = 0; i <= snowMax; i++) { - coords[i] += pos[i]; - snow[i].posY += snow[i].sink; - snow[i].style.left = snow[i].posX + lefr[i] * Math.sin(coords[i]) + "px"; - snow[i].style.top = snow[i].posY + "px"; + for (i = 0; i <= snowMax; i++) { + coords[i] += pos[i]; + snow[i].posY += snow[i].sink; + snow[i].style.left = snow[i].posX + lefr[i] * Math.sin(coords[i]) + "px"; + snow[i].style.top = snow[i].posY + "px"; + - if (snow[i].posY >= marginBottom - 2 * snow[i].size || parseInt(snow[i].style.left) > (marginRight - 3 * lefr[i])) { - snow[i].posX = randomise(marginRight - snow[i].size); - snow[i].posY = 0; - } + if (snow[i].posY >= marginBottom - 2 * snow[i].size || parseInt(snow[i].style.left) > (marginRight - 3 * lefr[i])) { + snow[i].posX = randomise(marginRight - snow[i].size); + snow[i].posY = 0; + } snow[i].rotation += snow[i].sink * snow[i].direction; // increment rotation based on direction snow[i].style.transform = "rotate(" + snow[i].rotation + "deg)"; // rotate the snowflake } - setTimeout("moveSnow()", snowRefresh); + setTimeout("moveSnow()", snowRefresh); } for (i = 0; i <= snowMax; i++) { - document.write("" + snowEntity + ""); + document.write("" + snowEntity + ""); } window.addEventListener('resize', resize); window.addEventListener('load', initSnow); +