various: extract magic numbers into named constants

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I854b2f9b5f39e4629c32e5681e6322826a6a6964

cmd/watchdog/root.go

@@ -11,13 +11,13 @@ import (
 	"path/filepath"
 	"strings"
 	"syscall"
-	"time"
 
 	"github.com/prometheus/client_golang/prometheus"
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	"notashelf.dev/watchdog/internal/aggregate"
 	"notashelf.dev/watchdog/internal/api"
 	"notashelf.dev/watchdog/internal/config"
+	"notashelf.dev/watchdog/internal/limits"
 	"notashelf.dev/watchdog/internal/normalize"
 )
 
@@ -91,9 +91,9 @@ func Run(cfg *config.Config) error {
 	srv := &http.Server{
 		Addr:         cfg.Server.ListenAddr,
 		Handler:      mux,
-		ReadTimeout:  10 * time.Second,
+		ReadTimeout:  limits.HTTPReadTimeout,
-		WriteTimeout: 10 * time.Second,
+		WriteTimeout: limits.HTTPWriteTimeout,
-		IdleTimeout:  60 * time.Second,
+		IdleTimeout:  limits.HTTPIdleTimeout,
 	}
 
 	// Start server in goroutine
@@ -115,8 +115,8 @@ func Run(cfg *config.Config) error {
 	case sig := <-shutdown:
 		log.Printf("Received signal: %v, starting graceful shutdown", sig)
 
-		// Give outstanding requests 30 seconds to complete
+		// Give outstanding requests time to complete
-		ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
+		ctx, cancel := context.WithTimeout(context.Background(), limits.ShutdownTimeout)
 		defer cancel()
 
 		// Shutdown metrics aggregator.

internal/aggregate/metrics.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/prometheus/client_golang/prometheus"
 	"notashelf.dev/watchdog/internal/config"
+	"notashelf.dev/watchdog/internal/limits"
 )
 
 var prometheusLabelPattern = regexp.MustCompile(`^[a-zA-Z0-9_/:.-]*$`)
@@ -121,11 +122,11 @@ func NewMetricsAggregator(
 	return m
 }
 
-// Background goroutine to update the unique visitors gauge every 10 seconds
+// Background goroutine to update the unique visitors gauge periodically
 // instead of on every request. This should help with performance.
 func (m *MetricsAggregator) updateUniquesGauge() {
 	defer m.wg.Done()
-	ticker := time.NewTicker(10 * time.Second)
+	ticker := time.NewTicker(limits.UniquesUpdatePeriod)
 	defer ticker.Stop()
 
 	for {

internal/limits/constants.go

@@ -1,5 +1,7 @@
 package limits
 
+import "time"
+
 // Size limits for request processing
 const (
 	MaxEventSize = 4 * 1024 // 4KB max event payload
@@ -7,3 +9,12 @@ const (
 	MaxRefLen    = 2048     // max referrer length
 	MaxWidth     = 10000    // max reasonable screen width
 )
+
+// Timeout constants
+const (
+	HTTPReadTimeout     = 10 * time.Second // HTTP server read timeout
+	HTTPWriteTimeout    = 10 * time.Second // HTTP server write timeout
+	HTTPIdleTimeout     = 60 * time.Second // HTTP server idle timeout
+	ShutdownTimeout     = 30 * time.Second // graceful shutdown timeout
+	UniquesUpdatePeriod = 10 * time.Second // HLL gauge update interval
+)

internal/normalize/path.go

@@ -4,6 +4,7 @@ import (
 	"strings"
 
 	"notashelf.dev/watchdog/internal/config"
+	"notashelf.dev/watchdog/internal/limits"
 )
 
 type PathNormalizer struct {
@@ -14,7 +15,7 @@ type PathNormalizer struct {
 func NewPathNormalizer(cfg config.PathConfig) *PathNormalizer {
 	return &PathNormalizer{
 		cfg:       cfg,
-		maxLength: 2048,
+		maxLength: limits.MaxPathLen,
 	}
 }