chore: bump deps; fix clippy lints & cleanup

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I4c4815ad145650a07f108614034d2e996a6a6964

crates/pinakes-server/tests/api.rs

@@ -29,6 +29,7 @@ use pinakes_core::{
     ThumbnailConfig,
     TlsConfig,
     TranscodingConfig,
+    TrashConfig,
     UiConfig,
     UserAccount,
     UserRole,
@@ -151,6 +152,7 @@ fn default_config() -> Config {
     managed_storage: ManagedStorageConfig::default(),
     sync:            SyncConfig::default(),
     sharing:         SharingConfig::default(),
+    trash:           TrashConfig::default(),
   }
 }
 
@@ -298,10 +300,6 @@ async fn response_body(
   serde_json::from_slice(&body).unwrap_or(serde_json::Value::Null)
 }
 
-// ===================================================================
-// Existing tests (no auth)
-// ===================================================================
-
 #[tokio::test]
 async fn test_list_media_empty() {
   let app = setup_app().await;
@@ -515,10 +513,6 @@ async fn test_user_duplicate_username() {
   assert_eq!(response.status(), StatusCode::CONFLICT);
 }
 
-// ===================================================================
-// Authentication tests
-// ===================================================================
-
 #[tokio::test]
 async fn test_unauthenticated_request_rejected() {
   let (app, ..) = setup_app_with_auth().await;
@@ -623,10 +617,6 @@ async fn test_logout() {
   assert_eq!(response.status(), StatusCode::UNAUTHORIZED);
 }
 
-// ===================================================================
-// Authorization / RBAC tests
-// ===================================================================
-
 #[tokio::test]
 async fn test_viewer_cannot_access_editor_routes() {
   let (app, _, _, viewer_token) = setup_app_with_auth().await;
@@ -713,10 +703,6 @@ async fn test_admin_can_access_all() {
   assert_eq!(response.status(), StatusCode::OK);
 }
 
-// ===================================================================
-// Phase 2 feature tests: Social
-// ===================================================================
-
 #[tokio::test]
 async fn test_rating_invalid_stars_zero() {
   let (app, _, editor_token, _) = setup_app_with_auth().await;
@@ -775,10 +761,6 @@ async fn test_favorites_list_empty() {
   assert!(body.as_array().unwrap().is_empty());
 }
 
-// ===================================================================
-// Phase 2 feature tests: Playlists
-// ===================================================================
-
 #[tokio::test]
 async fn test_playlist_crud() {
   let (app, _, editor_token, _) = setup_app_with_auth().await;
@@ -860,10 +842,6 @@ async fn test_playlist_empty_name() {
   assert_eq!(response.status(), StatusCode::BAD_REQUEST);
 }
 
-// ===================================================================
-// Phase 2 feature tests: Analytics
-// ===================================================================
-
 #[tokio::test]
 async fn test_most_viewed_empty() {
   let (app, _, _, viewer_token) = setup_app_with_auth().await;
@@ -896,10 +874,6 @@ async fn test_record_event_and_query() {
   assert_eq!(body["recorded"], true);
 }
 
-// ===================================================================
-// Phase 2 feature tests: Streaming/Transcode
-// ===================================================================
-
 #[tokio::test]
 async fn test_transcode_session_not_found() {
   let (app, _, _, viewer_token) = setup_app_with_auth().await;
@@ -951,10 +925,6 @@ async fn test_hls_segment_no_session() {
   );
 }
 
-// ===================================================================
-// Phase 2 feature tests: Subtitles
-// ===================================================================
-
 #[tokio::test]
 async fn test_subtitles_list() {
   let (app, _, _, viewer_token) = setup_app_with_auth().await;
@@ -974,10 +944,6 @@ async fn test_subtitles_list() {
   );
 }
 
-// ===================================================================
-// Health: public access test
-// ===================================================================
-
 #[tokio::test]
 async fn test_health_public() {
   let (app, ..) = setup_app_with_auth().await;
@@ -988,10 +954,6 @@ async fn test_health_public() {
   assert_eq!(response.status(), StatusCode::OK);
 }
 
-// ===================================================================
-// Input validation & edge case tests
-// ===================================================================
-
 #[tokio::test]
 async fn test_invalid_uuid_in_path() {
   let (app, _, _, viewer_token) = setup_app_with_auth().await;
@@ -1026,7 +988,7 @@ async fn test_share_link_expired() {
   // (need real media items). Verify the expire check logic works.
   let app = setup_app().await;
 
-  // First import a dummy file to get a media_id — but we can't without a real
+  // First import a dummy file to get a media_id, but we can't without a real
   // file. So let's test the public share access endpoint with a nonexistent
   // token.
   let response = app

crates/pinakes-server/tests/plugin.rs

@@ -29,6 +29,7 @@ use pinakes_core::{
     ThumbnailConfig,
     TlsConfig,
     TranscodingConfig,
+    TrashConfig,
     UiConfig,
     WebhookConfig,
   },
@@ -118,6 +119,7 @@ async fn setup_app_with_plugins()
     managed_storage: ManagedStorageConfig::default(),
     sync:            SyncConfig::default(),
     sharing:         SharingConfig::default(),
+    trash:           TrashConfig::default(),
   };
 
   let job_queue =