From 54fffa3c9687d4e15725f180b44eef94aa925739 Mon Sep 17 00:00:00 2001
From: NotAShelf <raf@notashelf.dev>
Date: Thu, 19 Mar 2026 23:57:48 +0300
Subject: [PATCH] pinakes-core: fix hasher usage in tests

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ied03277d450e39299470667ef479c3526a6a6964
---
 crates/pinakes-core/src/config.rs         | 24 +++++++++++++++++------
 crates/pinakes-core/src/plugin/runtime.rs |  3 ++-
 crates/pinakes-core/src/storage/mod.rs    |  2 +-
 3 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/crates/pinakes-core/src/config.rs b/crates/pinakes-core/src/config.rs
index 0725308..ecc8ae8 100644
--- a/crates/pinakes-core/src/config.rs
+++ b/crates/pinakes-core/src/config.rs
@@ -1567,21 +1567,27 @@ mod tests {
 
   #[test]
   fn test_expand_env_var_simple() {
-    let vars = FxHashMap::from([("TEST_VAR_SIMPLE", "test_value")]);
+    let vars = [("TEST_VAR_SIMPLE", "test_value")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result = expand_env_vars("$TEST_VAR_SIMPLE", test_lookup(&vars));
     assert_eq!(result.unwrap(), "test_value");
   }
 
   #[test]
   fn test_expand_env_var_braces() {
-    let vars = FxHashMap::from([("TEST_VAR_BRACES", "test_value")]);
+    let vars = [("TEST_VAR_BRACES", "test_value")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result = expand_env_vars("${TEST_VAR_BRACES}", test_lookup(&vars));
     assert_eq!(result.unwrap(), "test_value");
   }
 
   #[test]
   fn test_expand_env_var_embedded() {
-    let vars = FxHashMap::from([("TEST_VAR_EMBEDDED", "value")]);
+    let vars = [("TEST_VAR_EMBEDDED", "value")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result =
       expand_env_vars("prefix_${TEST_VAR_EMBEDDED}_suffix", test_lookup(&vars));
     assert_eq!(result.unwrap(), "prefix_value_suffix");
@@ -1589,7 +1595,9 @@ mod tests {
 
   #[test]
   fn test_expand_env_var_multiple() {
-    let vars = FxHashMap::from([("VAR1", "value1"), ("VAR2", "value2")]);
+    let vars = [("VAR1", "value1"), ("VAR2", "value2")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result = expand_env_vars("${VAR1}_${VAR2}", test_lookup(&vars));
     assert_eq!(result.unwrap(), "value1_value2");
   }
@@ -1636,14 +1644,18 @@ mod tests {
 
   #[test]
   fn test_expand_env_var_underscore() {
-    let vars = FxHashMap::from([("TEST_VAR_NAME", "value")]);
+    let vars = [("TEST_VAR_NAME", "value")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result = expand_env_vars("$TEST_VAR_NAME", test_lookup(&vars));
     assert_eq!(result.unwrap(), "value");
   }
 
   #[test]
   fn test_expand_env_var_mixed_syntax() {
-    let vars = FxHashMap::from([("VAR1_MIXED", "v1"), ("VAR2_MIXED", "v2")]);
+    let vars = [("VAR1_MIXED", "v1"), ("VAR2_MIXED", "v2")]
+      .into_iter()
+      .collect::<FxHashMap<_, _>>();
     let result =
       expand_env_vars("$VAR1_MIXED and ${VAR2_MIXED}", test_lookup(&vars));
     assert_eq!(result.unwrap(), "v1 and v2");
diff --git a/crates/pinakes-core/src/plugin/runtime.rs b/crates/pinakes-core/src/plugin/runtime.rs
index 6a363e7..b550b05 100644
--- a/crates/pinakes-core/src/plugin/runtime.rs
+++ b/crates/pinakes-core/src/plugin/runtime.rs
@@ -775,6 +775,7 @@ impl HostFunctions {
 #[cfg(test)]
 mod tests {
   use pinakes_plugin_api::PluginContext;
+  use rustc_hash::FxHashMap;
 
   use super::*;
 
@@ -836,7 +837,7 @@ mod tests {
     let mut context = PluginContext {
       data_dir:     "/tmp/data".into(),
       cache_dir:    "/tmp/cache".into(),
-      config:       HashMap::new(),
+      config:       FxHashMap::default(),
       capabilities: Default::default(),
     };
 
diff --git a/crates/pinakes-core/src/storage/mod.rs b/crates/pinakes-core/src/storage/mod.rs
index 5e5cdcd..e1d93bc 100644
--- a/crates/pinakes-core/src/storage/mod.rs
+++ b/crates/pinakes-core/src/storage/mod.rs
@@ -1172,7 +1172,7 @@ pub trait StorageBackend: Send + Sync + 'static {
 
   /// Create a backup of the database to the specified path.
   ///
-  /// Only supported for SQLite (uses VACUUM INTO). PostgreSQL
+  /// Only supported for `SQLite` (uses VACUUM INTO). `PostgreSQL`
   /// deployments should use `pg_dump` directly; this method returns
   /// `PinakesError::InvalidOperation` for unsupported backends.
   async fn backup(&self, _dest: &std::path::Path) -> Result<()> {