pinakes-core: update remaining modules and tests

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: I9e0ff5ea33a5cf697473423e88f167ce6a6a6964

crates/pinakes-core/src/plugin/registry.rs

@@ -26,6 +26,7 @@ pub struct PluginRegistry {
 
 impl PluginRegistry {
   /// Create a new empty registry
+  #[must_use]
   pub fn new() -> Self {
     Self {
       plugins: HashMap::new(),
@@ -33,6 +34,10 @@ impl PluginRegistry {
   }
 
   /// Register a new plugin
+  ///
+  /// # Errors
+  ///
+  /// Returns an error if a plugin with the same ID is already registered.
   pub fn register(&mut self, plugin: RegisteredPlugin) -> Result<()> {
     if self.plugins.contains_key(&plugin.id) {
       return Err(anyhow!("Plugin already registered: {}", plugin.id));
@@ -43,15 +48,20 @@ impl PluginRegistry {
   }
 
   /// Unregister a plugin by ID
+  ///
+  /// # Errors
+  ///
+  /// Returns an error if the plugin ID is not found.
   pub fn unregister(&mut self, plugin_id: &str) -> Result<()> {
     self
       .plugins
       .remove(plugin_id)
-      .ok_or_else(|| anyhow!("Plugin not found: {}", plugin_id))?;
+      .ok_or_else(|| anyhow!("Plugin not found: {plugin_id}"))?;
     Ok(())
   }
 
   /// Get a plugin by ID
+  #[must_use]
   pub fn get(&self, plugin_id: &str) -> Option<&RegisteredPlugin> {
     self.plugins.get(plugin_id)
   }
@@ -62,48 +72,61 @@ impl PluginRegistry {
   }
 
   /// Check if a plugin is loaded
+  #[must_use]
   pub fn is_loaded(&self, plugin_id: &str) -> bool {
     self.plugins.contains_key(plugin_id)
   }
 
   /// Check if a plugin is enabled. Returns `None` if the plugin is not found.
+  #[must_use]
   pub fn is_enabled(&self, plugin_id: &str) -> Option<bool> {
     self.plugins.get(plugin_id).map(|p| p.enabled)
   }
 
   /// Enable a plugin
+  ///
+  /// # Errors
+  ///
+  /// Returns an error if the plugin ID is not found.
   pub fn enable(&mut self, plugin_id: &str) -> Result<()> {
     let plugin = self
       .plugins
       .get_mut(plugin_id)
-      .ok_or_else(|| anyhow!("Plugin not found: {}", plugin_id))?;
+      .ok_or_else(|| anyhow!("Plugin not found: {plugin_id}"))?;
 
     plugin.enabled = true;
     Ok(())
   }
 
   /// Disable a plugin
+  ///
+  /// # Errors
+  ///
+  /// Returns an error if the plugin ID is not found.
   pub fn disable(&mut self, plugin_id: &str) -> Result<()> {
     let plugin = self
       .plugins
       .get_mut(plugin_id)
-      .ok_or_else(|| anyhow!("Plugin not found: {}", plugin_id))?;
+      .ok_or_else(|| anyhow!("Plugin not found: {plugin_id}"))?;
 
     plugin.enabled = false;
     Ok(())
   }
 
   /// List all registered plugins
+  #[must_use]
   pub fn list_all(&self) -> Vec<&RegisteredPlugin> {
     self.plugins.values().collect()
   }
 
   /// List all enabled plugins
+  #[must_use]
   pub fn list_enabled(&self) -> Vec<&RegisteredPlugin> {
     self.plugins.values().filter(|p| p.enabled).collect()
   }
 
-  /// Get plugins by kind (e.g., "media_type", "metadata_extractor")
+  /// Get plugins by kind (e.g., "`media_type`", "`metadata_extractor`")
+  #[must_use]
   pub fn get_by_kind(&self, kind: &str) -> Vec<&RegisteredPlugin> {
     self
       .plugins
@@ -113,11 +136,13 @@ impl PluginRegistry {
   }
 
   /// Get count of registered plugins
+  #[must_use]
   pub fn count(&self) -> usize {
     self.plugins.len()
   }
 
   /// Get count of enabled plugins
+  #[must_use]
   pub fn count_enabled(&self) -> usize {
     self.plugins.values().filter(|p| p.enabled).count()
   }
@@ -182,7 +207,7 @@ mod tests {
     let plugin =
       create_test_plugin("test-plugin", vec!["media_type".to_string()]);
 
-    registry.register(plugin.clone()).unwrap();
+    registry.register(plugin).unwrap();
 
     assert!(registry.is_loaded("test-plugin"));
     assert!(registry.get("test-plugin").is_some());