From 1f7d7ea92591f65f3821eabf15f7292473afa673 Mon Sep 17 00:00:00 2001 From: NotAShelf Date: Thu, 12 Mar 2026 20:48:15 +0300 Subject: [PATCH] pinakes-server: warn on backup cleanup failure; add error logging around `clear_database` Signed-off-by: NotAShelf Change-Id: I903ce59772c16883642c82427be8167a6a6a6964 --- crates/pinakes-server/src/routes/backup.rs | 4 +++- crates/pinakes-server/src/routes/database.rs | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/pinakes-server/src/routes/backup.rs b/crates/pinakes-server/src/routes/backup.rs index dcca2b7..4af2b18 100644 --- a/crates/pinakes-server/src/routes/backup.rs +++ b/crates/pinakes-server/src/routes/backup.rs @@ -31,7 +31,9 @@ pub async fn create_backup( let bytes = tokio::fs::read(&backup_path) .await .map_err(|e| ApiError(pinakes_core::error::PinakesError::Io(e)))?; - let _ = tokio::fs::remove_dir_all(&backup_dir).await; + if let Err(e) = tokio::fs::remove_dir_all(&backup_dir).await { + tracing::warn!(path = %backup_dir.display(), error = %e, "failed to clean up backup temp dir"); + } let disposition = format!("attachment; filename=\"{filename}\""); Ok( diff --git a/crates/pinakes-server/src/routes/database.rs b/crates/pinakes-server/src/routes/database.rs index 6338382..4c71cde 100644 --- a/crates/pinakes-server/src/routes/database.rs +++ b/crates/pinakes-server/src/routes/database.rs @@ -26,6 +26,8 @@ pub async fn vacuum_database( pub async fn clear_database( State(state): State, ) -> Result, ApiError> { + tracing::error!("clear_database: all data is being wiped by admin request"); state.storage.clear_all_data().await?; + tracing::error!("clear_database: all data wiped successfully"); Ok(Json(serde_json::json!({"status": "ok"}))) }