treewide: cleanup

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ia01590cdeed872cc8ebd16f6ca95f3cc6a6a6964

crates/pinakes-core/src/plugin/mod.rs

@@ -607,42 +607,12 @@ impl PluginManager {
   pub async fn list_ui_pages(
     &self,
   ) -> Vec<(String, pinakes_plugin_api::UiPage)> {
-    let registry = self.registry.read().await;
-    let mut pages = Vec::new();
-    for plugin in registry.list_all() {
-      if !plugin.enabled {
-        continue;
-      }
-      let plugin_dir = plugin
-        .manifest_path
-        .as_ref()
-        .and_then(|p| p.parent())
-        .map(std::path::Path::to_path_buf);
-      let Some(plugin_dir) = plugin_dir else {
-        // No manifest path; serve only inline pages.
-        for entry in &plugin.manifest.ui.pages {
-          if let pinakes_plugin_api::manifest::UiPageEntry::Inline(page) = entry
-          {
-            pages.push((plugin.id.clone(), (**page).clone()));
-          }
-        }
-        continue;
-      };
-      match plugin.manifest.load_ui_pages(&plugin_dir) {
-        Ok(loaded) => {
-          for page in loaded {
-            pages.push((plugin.id.clone(), page));
-          }
-        },
-        Err(e) => {
-          tracing::warn!(
-            "Failed to load UI pages for plugin '{}': {e}",
-            plugin.id
-          );
-        },
-      }
-    }
-    pages
+    self
+      .list_ui_pages_with_endpoints()
+      .await
+      .into_iter()
+      .map(|(id, page, _)| (id, page))
+      .collect()
   }
 
   /// List all UI pages provided by loaded plugins, including each plugin's