mirror of
https://github.com/NotAShelf/nvf.git
synced 2025-02-24 12:28:32 +00:00
Compare commits
3 commits
88034ac4c6
...
4858a6998c
Author | SHA1 | Date | |
---|---|---|---|
![]() |
4858a6998c | ||
618e709276 | |||
90fbfe1d6c |
1 changed files with 30 additions and 31 deletions
61
.github/pull_request_template.md
vendored
61
.github/pull_request_template.md
vendored
|
@ -9,45 +9,44 @@ below this line. You may attach an issue to your pull request with `Fixes #<issu
|
|||
this comment.
|
||||
-->
|
||||
|
||||
## Type of change
|
||||
|
||||
<!--
|
||||
Please check all that apply. This section is not a hard requirement, but it helps prioritize critical pull requests
|
||||
for reviewers and contributors.
|
||||
-->
|
||||
|
||||
- [ ] Bug fix (**non-breaking** change which fixes an issue)
|
||||
- [ ] New feature (**non-breaking** change which adds functionality)
|
||||
- [ ] Breaking change (fix or feature that would cause existing functionality to
|
||||
not work as expected)
|
||||
- [ ] Translation/Language update
|
||||
- [ ] Changes to module documentation or the nvf manual (`docs/manual`)
|
||||
- [ ] Other
|
||||
|
||||
## Sanity Checking
|
||||
|
||||
<!--
|
||||
Please check all that apply. As before, this section is not a hard requirement but checklists with more checked
|
||||
items are likely to be merged faster. You may save some time in maintainer review by performing self-reviews here
|
||||
before submitting your pull request.
|
||||
|
||||
If your pull request includes any change or unexpected behaviour not covered below, please do make sure to include
|
||||
it above in your description.
|
||||
-->
|
||||
|
||||
[editorconfig]: https://editorconfig.org
|
||||
[changelog]: https://github.com/NotAShelf/nvf/tree/main/docs/release-notes
|
||||
|
||||
- [ ] I have updated the [changelog] as per my changes.
|
||||
- [ ] I have tested, and self-reviewed my code.
|
||||
- Style and consistency
|
||||
- [ ] I ran **Alejandra** to format my code (`nix fmt`).
|
||||
- [ ] My code conforms to the [editorconfig] configuration of the project.
|
||||
- [ ] My changes are consistent with the rest of the codebase.
|
||||
- If new changes are particularly complex:
|
||||
- [ ] My code includes comments in particularly complex areas
|
||||
- [ ] I have added a section in the manual.
|
||||
- [ ] _(For breaking changes)_ I have included a migration guide.
|
||||
- Package(s) built:
|
||||
- [ ] `.#nix` (default package)
|
||||
- [ ] `.#maximal`
|
||||
- [ ] `.#docs-html`
|
||||
- Tested on platform(s)
|
||||
- [ ] `x86_64-linux`
|
||||
- [ ] `aarch64-linux`
|
||||
- [ ] `x86_64-darwin`
|
||||
- [ ] `aarch64-darwin`
|
||||
|
||||
<!--
|
||||
If your changes touch upon a portion of the codebase that you do not understand well, please make sure to consult
|
||||
the maintainers on your changes. In most cases, making an issue before creating your PR will help you avoid duplicate
|
||||
efforts in the long run.
|
||||
-->
|
||||
- [ ] My code follows the style and contributing guidelines of this project.
|
||||
- [ ] I ran Alejandra to format my code (`nix fmt`).
|
||||
- [ ] My code conforms to the `Editorconfig` styles in the project root.
|
||||
- [ ] I have performed a self-review of my own code and tested it.
|
||||
- Package(s) built:
|
||||
- [ ] `.#nix`
|
||||
- [ ] `.#maximal`
|
||||
- [ ] `.#docs-html`
|
||||
- [ ] I have commented my code, particularly in hard-to-understand areas.
|
||||
- [ ] My changes generate no new errors or warnings.
|
||||
- [ ] This change requires a documentation update.
|
||||
- [ ] I have have added a change-log entry (see `docs/manual/release-notes`).
|
||||
- If new changes are particularly complex:
|
||||
- [ ] I have added a section in the manual.
|
||||
- [ ] (For breaking changes) I have included a migration guide..
|
||||
|
||||
---
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue