From ae1922f6dad54b410927d29a4cd8870792e92583 Mon Sep 17 00:00:00 2001 From: alfarel Date: Fri, 26 Sep 2025 18:44:04 +0000 Subject: [PATCH] treewide: don't import modules manually Reduces maintenance burden. --- modules/plugins/assistant/chatgpt/config.nix | 4 ++-- modules/plugins/git/git-conflict/config.nix | 4 ++-- modules/plugins/git/gitsigns/config.nix | 4 ++-- modules/plugins/lsp/config.nix | 5 ++--- modules/plugins/lsp/nvim-docs-view/config.nix | 4 ++-- modules/plugins/lsp/otter/config.nix | 4 ++-- modules/plugins/minimap/codewindow/config.nix | 5 ++--- modules/plugins/notes/todo-comments/config.nix | 5 ++--- modules/plugins/tabline/nvim-bufferline/config.nix | 5 +++-- modules/plugins/treesitter/config.nix | 5 ++--- modules/plugins/utility/gestures/gesture-nvim/config.nix | 5 ++--- modules/plugins/utility/motion/hop/config.nix | 5 ++--- modules/plugins/utility/preview/glow/config.nix | 6 ++---- 13 files changed, 27 insertions(+), 34 deletions(-) diff --git a/modules/plugins/assistant/chatgpt/config.nix b/modules/plugins/assistant/chatgpt/config.nix index b1066e5a..bf4d9972 100644 --- a/modules/plugins/assistant/chatgpt/config.nix +++ b/modules/plugins/assistant/chatgpt/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -10,8 +11,7 @@ cfg = config.vim.assistant.chatgpt; - self = import ./chatgpt.nix {inherit lib;}; - mappingDefinitions = self.options.vim.assistant.chatgpt.mappings; + mappingDefinitions = options.vim.assistant.chatgpt.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; maps = mkMerge [ (mkSetBinding mappings.editWithInstructions "ChatGPTEditWithInstruction") diff --git a/modules/plugins/git/git-conflict/config.nix b/modules/plugins/git/git-conflict/config.nix index bc9905d6..9d99aacc 100644 --- a/modules/plugins/git/git-conflict/config.nix +++ b/modules/plugins/git/git-conflict/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -10,8 +11,7 @@ cfg = config.vim.git.git-conflict; - self = import ./git-conflict.nix {inherit lib config;}; - gcMappingDefinitions = self.options.vim.git.git-conflict.mappings; + gcMappingDefinitions = options.vim.git.git-conflict.mappings; gcMappings = addDescriptionsToMappings cfg.mappings gcMappingDefinitions; in { diff --git a/modules/plugins/git/gitsigns/config.nix b/modules/plugins/git/gitsigns/config.nix index e89eebcf..e2d31df5 100644 --- a/modules/plugins/git/gitsigns/config.nix +++ b/modules/plugins/git/gitsigns/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (builtins) toJSON; @@ -12,8 +13,7 @@ cfg = config.vim.git.gitsigns; - self = import ./gitsigns.nix {inherit lib config;}; - gsMappingDefinitions = self.options.vim.git.gitsigns.mappings; + gsMappingDefinitions = options.vim.git.gitsigns.mappings; gsMappings = addDescriptionsToMappings cfg.mappings gsMappingDefinitions; in { diff --git a/modules/plugins/lsp/config.nix b/modules/plugins/lsp/config.nix index e7b67c8e..d6875205 100644 --- a/modules/plugins/lsp/config.nix +++ b/modules/plugins/lsp/config.nix @@ -1,7 +1,7 @@ { config, lib, - pkgs, + options, ... }: let inherit (lib.generators) mkLuaInline; @@ -14,12 +14,11 @@ cfg = config.vim.lsp; usingNvimCmp = config.vim.autocomplete.nvim-cmp.enable; usingBlinkCmp = config.vim.autocomplete.blink-cmp.enable; - self = import ./module.nix {inherit config lib pkgs;}; conformCfg = config.vim.formatter.conform-nvim; conformFormatOnSave = conformCfg.enable && conformCfg.setupOpts.format_on_save != null; augroup = "nvf_lsp"; - mappingDefinitions = self.options.vim.lsp.mappings; + mappingDefinitions = options.vim.lsp.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; mkBinding = binding: action: if binding.value != null diff --git a/modules/plugins/lsp/nvim-docs-view/config.nix b/modules/plugins/lsp/nvim-docs-view/config.nix index 5c7ad2b7..997e9a72 100644 --- a/modules/plugins/lsp/nvim-docs-view/config.nix +++ b/modules/plugins/lsp/nvim-docs-view/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -9,9 +10,8 @@ inherit (lib.nvim.lua) toLuaObject; cfg = config.vim.lsp.nvim-docs-view; - self = import ./nvim-docs-view.nix {inherit lib;}; - mappingDefinitions = self.options.vim.lsp.nvim-docs-view.mappings; + mappingDefinitions = options.vim.lsp.nvim-docs-view.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; in { config = mkIf cfg.enable { diff --git a/modules/plugins/lsp/otter/config.nix b/modules/plugins/lsp/otter/config.nix index 85f24c70..f3dbe4d6 100644 --- a/modules/plugins/lsp/otter/config.nix +++ b/modules/plugins/lsp/otter/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -10,8 +11,7 @@ cfg = config.vim.lsp; - self = import ./otter.nix {inherit lib;}; - mappingDefinitions = self.options.vim.lsp.otter-nvim.mappings; + mappingDefinitions = options.vim.lsp.otter-nvim.mappings; mappings = addDescriptionsToMappings cfg.otter-nvim.mappings mappingDefinitions; in { config = mkIf (cfg.enable && cfg.otter-nvim.enable) { diff --git a/modules/plugins/minimap/codewindow/config.nix b/modules/plugins/minimap/codewindow/config.nix index a853514a..8a62ee04 100644 --- a/modules/plugins/minimap/codewindow/config.nix +++ b/modules/plugins/minimap/codewindow/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -9,9 +10,7 @@ cfg = config.vim.minimap.codewindow; - self = import ./codewindow.nix {inherit lib;}; - - mappingDefinitions = self.options.vim.minimap.codewindow.mappings; + mappingDefinitions = options.vim.minimap.codewindow.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; in { config = mkIf cfg.enable { diff --git a/modules/plugins/notes/todo-comments/config.nix b/modules/plugins/notes/todo-comments/config.nix index b03efce4..47fa3641 100644 --- a/modules/plugins/notes/todo-comments/config.nix +++ b/modules/plugins/notes/todo-comments/config.nix @@ -1,7 +1,7 @@ { - pkgs, config, lib, + options, ... }: let inherit (lib.modules) mkMerge mkIf; @@ -9,8 +9,7 @@ inherit (lib.nvim.lua) toLuaObject; cfg = config.vim.notes.todo-comments; - self = import ./todo-comments.nix {inherit pkgs lib;}; - inherit (self.options.vim.notes.todo-comments) mappings; + inherit (options.vim.notes.todo-comments) mappings; in { config = mkIf cfg.enable { vim = { diff --git a/modules/plugins/tabline/nvim-bufferline/config.nix b/modules/plugins/tabline/nvim-bufferline/config.nix index 965f81f0..fc7402b3 100644 --- a/modules/plugins/tabline/nvim-bufferline/config.nix +++ b/modules/plugins/tabline/nvim-bufferline/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -9,8 +10,8 @@ inherit (lib.nvim.lua) toLuaObject; cfg = config.vim.tabline.nvimBufferline; - self = import ./nvim-bufferline.nix {inherit config lib;}; - inherit (self.options.vim.tabline.nvimBufferline) mappings; + + inherit (options.vim.tabline.nvimBufferline) mappings; in { config = mkIf cfg.enable { vim = { diff --git a/modules/plugins/treesitter/config.nix b/modules/plugins/treesitter/config.nix index 14aba5e1..f7955110 100644 --- a/modules/plugins/treesitter/config.nix +++ b/modules/plugins/treesitter/config.nix @@ -1,7 +1,7 @@ { config, - pkgs, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -12,8 +12,7 @@ cfg = config.vim.treesitter; - self = import ./treesitter.nix {inherit pkgs lib;}; - mappingDefinitions = self.options.vim.treesitter.mappings; + mappingDefinitions = options.vim.treesitter.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; in { config = mkIf cfg.enable { diff --git a/modules/plugins/utility/gestures/gesture-nvim/config.nix b/modules/plugins/utility/gestures/gesture-nvim/config.nix index 9838c178..6c40e3ea 100644 --- a/modules/plugins/utility/gestures/gesture-nvim/config.nix +++ b/modules/plugins/utility/gestures/gesture-nvim/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -9,9 +10,7 @@ cfg = config.vim.gestures.gesture-nvim; - self = import ./gesture-nvim.nix {inherit lib;}; - - mappingDefinitions = self.options.vim.gestures.gesture-nvim.mappings; + mappingDefinitions = options.vim.gestures.gesture-nvim.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; in { config = mkIf cfg.enable { diff --git a/modules/plugins/utility/motion/hop/config.nix b/modules/plugins/utility/motion/hop/config.nix index 505b9ebb..ef494309 100644 --- a/modules/plugins/utility/motion/hop/config.nix +++ b/modules/plugins/utility/motion/hop/config.nix @@ -1,6 +1,7 @@ { config, lib, + options, ... }: let inherit (lib.modules) mkIf; @@ -9,9 +10,7 @@ cfg = config.vim.utility.motion.hop; - self = import ./hop.nix {inherit lib;}; - - mappingDefinitions = self.options.vim.utility.motion.hop.mappings; + mappingDefinitions = options.vim.utility.motion.hop.mappings; mappings = addDescriptionsToMappings cfg.mappings mappingDefinitions; in { config = mkIf cfg.enable { diff --git a/modules/plugins/utility/preview/glow/config.nix b/modules/plugins/utility/preview/glow/config.nix index 4529a534..7297df83 100644 --- a/modules/plugins/utility/preview/glow/config.nix +++ b/modules/plugins/utility/preview/glow/config.nix @@ -2,6 +2,7 @@ pkgs, config, lib, + options, ... }: let inherit (lib.modules) mkIf mkMerge; @@ -9,10 +10,7 @@ inherit (lib.nvim.dag) entryAnywhere; cfg = config.vim.utility.preview.glow; - self = import ./glow.nix { - inherit lib config pkgs; - }; - inherit (self.options.vim.utility.preview.glow) mappings; + inherit (options.vim.utility.preview.glow) mappings; in { config = mkIf cfg.enable { vim.startPlugins = ["glow-nvim"];