From 8265ea062b4c37dc1b9846ec83bb8c9615048ef1 Mon Sep 17 00:00:00 2001 From: Dobry Nikolov Date: Tue, 2 Jun 2026 20:30:19 +0300 Subject: [PATCH] filetree/nvimtree: remove deprecated `system_open` option (#1622) --- docs/manual/release-notes/rl-0.9.md | 5 ++++ modules/extra/deprecations.nix | 10 ++++++++ .../plugins/filetree/nvimtree/nvimtree.nix | 23 ------------------- 3 files changed, 15 insertions(+), 23 deletions(-) diff --git a/docs/manual/release-notes/rl-0.9.md b/docs/manual/release-notes/rl-0.9.md index b819ba83..679f05ae 100644 --- a/docs/manual/release-notes/rl-0.9.md +++ b/docs/manual/release-notes/rl-0.9.md @@ -130,6 +130,11 @@ ## Changelog {#sec-release-0-9-changelog} +[bovf](https://github.com/bovf): + +- Removed the deprecated `system_open` setup option from `nvim-tree.lua` to + avoid startup warnings now that upstream uses `vim.ui.open()`. + [ErinaYip](https://github.com/ErinaYip): - Fixed and updated `lualine` options: diff --git a/modules/extra/deprecations.nix b/modules/extra/deprecations.nix index 6ad2e633..8ec5a3ef 100644 --- a/modules/extra/deprecations.nix +++ b/modules/extra/deprecations.nix @@ -378,5 +378,15 @@ in { [ (mkRenamedOptionModule ["vim" "languages" "typescript" "treesitter" "tsxPackage"] ["vim" "languages" "tsx" "treesitter" "package"]) ] + + # 2026-06-02 + [ + (mkRemovedOptionModule ["vim" "filetree" "nvimTree" "systemOpen" "args"] '' + nvim-tree.lua removed system_open and now uses Neovim's vim.ui.open(). + '') + (mkRemovedOptionModule ["vim" "filetree" "nvimTree" "systemOpen" "cmd"] '' + nvim-tree.lua removed system_open and now uses Neovim's vim.ui.open(). + '') + ] ]; } diff --git a/modules/plugins/filetree/nvimtree/nvimtree.nix b/modules/plugins/filetree/nvimtree/nvimtree.nix index e3d36703..1bfdcb27 100644 --- a/modules/plugins/filetree/nvimtree/nvimtree.nix +++ b/modules/plugins/filetree/nvimtree/nvimtree.nix @@ -28,10 +28,6 @@ reloadOnBufEnter = "reload_on_buf_enter"; respectBufCwd = "respect_buf_cwd"; hijackDirectories = "hijack_directories"; - systemOpen = { - args = "args"; - cmd = "cmd"; - }; diagnostics = "diagnostics"; git = { enable = "enable"; @@ -228,25 +224,6 @@ in { }; }; - system_open = { - args = mkOption { - default = []; - description = "Optional argument list."; - type = listOf str; - }; - - cmd = mkOption { - default = - if pkgs.stdenv.isDarwin - then "open" - else if pkgs.stdenv.isLinux - then "${pkgs.xdg-utils}/bin/xdg-open" - else throw "NvimTree: No default system open command for this platform, please set `vim.filetree.nvimTree.systemOpen.cmd`"; - description = "The open command itself"; - type = str; - }; - }; - diagnostics = mkOption { description = '' Show LSP and COC diagnostics in the signcolumn