nvf/.github/pull_request_template.md

57 lines
2.3 KiB
Markdown
Raw Normal View History

<!--
^ Please include a clear and concise description of the aim of your Pull Request above this line ^
2023-02-16 19:09:54 +00:00
For plugin dependency/module additions, please make sure to link the source link of the added plugin
or dependency in this section.
2023-02-16 19:09:54 +00:00
If your pull request aims to fix an open issue or a please bug, please also link the relevant issue
below this line. You may attach an issue to your pull request with `Fixes #<issue number>` outside
this comment.
-->
2023-02-16 19:09:54 +00:00
## Type of change
<!--
Please check all that apply. This section is not a hard requirement, but it helps prioritize critical pull requests
for reviewers and contributors.
-->
2023-02-16 19:09:54 +00:00
- [ ] Bug fix (**non-breaking** change which fixes an issue)
- [ ] New feature (**non-breaking** change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
- [ ] Translation/Language update
- [ ] Changes to module documentation or the nvf manual (`docs/manual`)
- [ ] Other
2023-02-16 19:09:54 +00:00
## Sanity Checking
2023-02-16 19:09:54 +00:00
<!--
Please check all that apply. As before, this section is not a hard requirement but checklists with more checked
items are likely to be merged faster. You may save some time in maintainer review by performing self-reviews here
before submitting your pull request.
-->
2023-02-16 19:09:54 +00:00
- [ ] My code follows the style and contributing guidelines of this project.
- [ ] I ran Alejandra to format my code (`nix fmt`).
- [ ] My code conforms to the `Editorconfig` styles in the project root.
2023-02-16 19:09:54 +00:00
- [ ] I have performed a self-review of my own code and tested it.
- Package(s) built:
- [ ] `.#nix`
- [ ] `.#maximal`
- [ ] `.#docs-html`
2023-02-16 19:09:54 +00:00
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] My changes generate no new errors or warnings.
2023-02-16 19:09:54 +00:00
- [ ] This change requires a documentation update.
- [ ] I have have added a change-log entry (see `docs/manual/release-notes`).
- If new changes are particularly complex:
- [ ] I have added a section in the manual.
- [ ] (For breaking changes) I have included a migration guide..
2023-02-16 19:09:54 +00:00
---
2023-02-16 19:09:54 +00:00
Add a :+1: [reaction] to [pull requests you find important].
2023-02-16 19:09:54 +00:00
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc