From 10a118bd50e6e5bac24e8ac8e1c310f1dd679f4c Mon Sep 17 00:00:00 2001
From: NotAShelf <raf@notashelf.dev>
Date: Sun, 8 Feb 2026 02:14:35 +0300
Subject: [PATCH] various: update tests for jobset state field changes

Signed-off-by: NotAShelf <raf@notashelf.dev>
Change-Id: Ifdd7f216fcc27fface0cb16d56c5e37b6a6a6964
---
 crates/common/src/validate.rs                | 6 +++++-
 crates/common/tests/repo_tests.rs            | 3 +++
 crates/common/tests/search_tests.rs          | 3 +++
 crates/common/tests/user_management_tests.rs | 2 ++
 crates/queue-runner/tests/runner_tests.rs    | 2 ++
 crates/server/tests/e2e_test.rs              | 1 +
 6 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/crates/common/src/validate.rs b/crates/common/src/validate.rs
index f48b564..fc56de4 100644
--- a/crates/common/src/validate.rs
+++ b/crates/common/src/validate.rs
@@ -6,12 +6,14 @@ use regex::Regex;
 
 /// Validate that a path is a valid nix store path.
 /// Rejects path traversal, overly long paths, and non-store paths.
+#[must_use] 
 pub fn is_valid_store_path(path: &str) -> bool {
   path.starts_with("/nix/store/") && !path.contains("..") && path.len() < 512
 }
 
 /// Validate that a string is a valid nix store hash (32 lowercase alphanumeric
 /// chars).
+#[must_use] 
 pub fn is_valid_nix_hash(hash: &str) -> bool {
   hash.len() == 32
     && hash
@@ -144,7 +146,7 @@ fn validate_forge_type(forge_type: &str) -> Result<(), String> {
 
 // --- Implementations ---
 
-use crate::models::*;
+use crate::models::{CreateProject, UpdateProject, CreateJobset, UpdateJobset, CreateEvaluation, CreateBuild, CreateChannel, UpdateChannel, CreateRemoteBuilder, UpdateRemoteBuilder, CreateWebhookConfig};
 
 impl Validate for CreateProject {
   fn validate(&self) -> Result<(), String> {
@@ -478,6 +480,7 @@ mod tests {
       check_interval:    Some(300),
       branch:            None,
       scheduling_shares: None,
+      state:             None,
     };
     assert!(j.validate().is_ok());
   }
@@ -493,6 +496,7 @@ mod tests {
       check_interval:    Some(5),
       branch:            None,
       scheduling_shares: None,
+      state:             None,
     };
     assert!(j.validate().is_err());
   }
diff --git a/crates/common/tests/repo_tests.rs b/crates/common/tests/repo_tests.rs
index ade758e..5303837 100644
--- a/crates/common/tests/repo_tests.rs
+++ b/crates/common/tests/repo_tests.rs
@@ -49,6 +49,7 @@ async fn create_test_jobset(
     check_interval: None,
     branch: None,
     scheduling_shares: None,
+    state: None,
   })
   .await
   .expect("create jobset")
@@ -191,6 +192,7 @@ async fn test_jobset_crud() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
@@ -219,6 +221,7 @@ async fn test_jobset_crud() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("update jobset");
diff --git a/crates/common/tests/search_tests.rs b/crates/common/tests/search_tests.rs
index 9bc7f25..cd18b88 100644
--- a/crates/common/tests/search_tests.rs
+++ b/crates/common/tests/search_tests.rs
@@ -116,6 +116,7 @@ async fn test_build_search_with_filters() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
@@ -261,6 +262,7 @@ async fn test_multi_entity_search() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
@@ -478,6 +480,7 @@ async fn test_quick_search() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
diff --git a/crates/common/tests/user_management_tests.rs b/crates/common/tests/user_management_tests.rs
index 489da02..e0f8378 100644
--- a/crates/common/tests/user_management_tests.rs
+++ b/crates/common/tests/user_management_tests.rs
@@ -363,6 +363,7 @@ async fn test_starred_jobs_crud() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
@@ -473,6 +474,7 @@ async fn test_starred_jobs_delete_by_job() {
     check_interval:    None,
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");
diff --git a/crates/queue-runner/tests/runner_tests.rs b/crates/queue-runner/tests/runner_tests.rs
index 659d037..1959f00 100644
--- a/crates/queue-runner/tests/runner_tests.rs
+++ b/crates/queue-runner/tests/runner_tests.rs
@@ -144,6 +144,7 @@ async fn test_atomic_build_claiming() {
       check_interval:    None,
       branch:            None,
       scheduling_shares: None,
+      state:             None,
     })
     .await
     .expect("create jobset");
@@ -235,6 +236,7 @@ async fn test_orphan_build_reset() {
       check_interval:    None,
       branch:            None,
       scheduling_shares: None,
+      state:             None,
     })
     .await
     .expect("create jobset");
diff --git a/crates/server/tests/e2e_test.rs b/crates/server/tests/e2e_test.rs
index 9d6a198..04080aa 100644
--- a/crates/server/tests/e2e_test.rs
+++ b/crates/server/tests/e2e_test.rs
@@ -63,6 +63,7 @@ async fn test_e2e_project_eval_build_flow() {
     check_interval:    Some(300),
     branch:            None,
     scheduling_shares: None,
+    state:             None,
   })
   .await
   .expect("create jobset");